Removing Stale i18n Keys #1008
Merged
Removing Stale i18n Keys #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting all the keys that I couldn't find used in the phone repo ... there's still some game-related ones I wasn't sure about
keys in main-metrics section related to the game, which is no longer a supported feature
|
All in, this is removing about 150 keys that aren't used anymore, which should streamline maintaining translations and adding new languages. As the app keeps changing, the translations strings needed likely will as well, and a "clean slate" should help with this. |
Abby-Wheelis
changed the base branch from
framework_migration_prep
to
aria_and_fall_2023_rewrite
shankari
requested changes
Aug 19, 2023
added 3 commits
August 19, 2023 10:41
There was one key that I eliminated because I could not find it used, it turns out the wrong key was being referenced so I restored the key and corrected the reference here
I had eliminated this key because it was not used, but in review we figured out where it was intended to be used and have restored it and updated the reference
was missing the consent.permissions key somehow, adding it back here
shankari
approved these changes
Aug 19, 2023
|
Ah! I found a couple of things that we're actually still wrong comparing to the translate version so there will be a small follow to this. I think I deleted some things by mistake somewhere along the way |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, I've deleted all the i18n keys I couldn't find used somewhere in the phone repo (aside from the dashboard "game" keys). This will make the translations easier to maintain.
Before this is ready, I need to test across as many different configurations as I can to make sure I don't remove keys that are needed somewhere.