Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contains filter and field to data_source_netbox_prefixes #617

Merged
merged 2 commits into from
Jul 17, 2024

Conversation

tagur87
Copy link
Contributor

@tagur87 tagur87 commented Jul 16, 2024

Add contains filter to data_source_netbox_prefixes

It is helpful to be able to look up the prefix by an IP address within
the prefix. The contains filter can be used for this.

If you specify an IP within a prefix, it will return that prefix.

Add site_id as a returned field to netbox_prefixes data source

It can be helpful to know the ID of the site that the prefixes are
assigned to. This allows us to reference it within in our TF code.

@tagur87
Copy link
Contributor Author

tagur87 commented Jul 16, 2024

@fbreckle - for your review. 😄

It is helpful to be able to look up the prefix by an IP address within
the prefix. The contains filter can be used for this.

If you specify an IP within a prefix, it will return that prefix.
@tagur87 tagur87 changed the title Add contains filter to data_source_netbox_prefixes Add contains filter and field to data_source_netbox_prefixes Jul 16, 2024
It can be helpful to know the ID of the site that the prefixes are
assigned to. This allows us to reference it within in our TF code.
@fbreckle
Copy link
Collaborator

On one hand I wonder if contains_ip would be a better name than contains, on the other hand, I want to implement #428 eventually and in that case, sticking to the name in the API would be better.

I'll go with contains.

@fbreckle fbreckle merged commit 548cd64 into e-breuninger:master Jul 17, 2024
14 checks passed
@tagur87
Copy link
Contributor Author

tagur87 commented Jul 22, 2024

@fbreckle - could we request a tag/release of the code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants