netbox_webhook: add additional attributes #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conditions are expected to returned as a json structure (not json encoded string). In the provider schema, it's possible to model a map with arbitrary typed values, so we have to provide this as a json encoded string. To prevent differently encoded json resulting in terraform showing whitespace differences, we implement a DiffSuppresFunc that checks if the old and new value are semantically equal. This mostly happens because by default `json.Marshal()` in go omits whitespace, while handcrafted json usually includes whitespace.
HCL is a superset of json. When providing json data through a heredoc,
terraform interprets it as an actual datastructure (maps / lists, etc)
and jsonencodes it itself.
Providing data like that will result in terraform always showing
whitespace changes like this:
```
~ body_template = jsonencode( # whitespace changes
{
text = "This is a sample json"
}
)
```
Use a DiffSuppressFunc to only show changes when there are semantic
differences.
|
I usually just merge when everything looks fine and no further chatting is required, so I want to take the extra time and say thank your for you contributions! :D |
Thanks, appreciate it, and you're welcome |
|
@fbreckle would it be possible to release a new version that includes this change? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for 2 additional attributes for the
netbox_webhookresource:additional_headersconditionsThis also fixes an issue with the
body_templateattribute, where terraform may keep showing changes to this field due to differences in json encoding: