is_pool issue with netbox_available_prefix

[cova-fe]

Terraform Version

Terraform v1.1.2

Affected Resource(s)

• netbox_available_prefix

Expected Behavior

the state of is_pool should be changed from true->false

Actual Behavior

The is_pool is not changed

Steps to Reproduce

Run terraform in order to request a new prefix, with is_pool set to true. Subsequently change the tf file to "is_bool: false". tf plan shows that the resource should be updated (true->false) as expected. run tf apply, the output shows that netbox is indeed called against the affected resources. However, the flag is not updated.

Important Factoids

I sniffed the API calls and while the provider indeed contacts the API, the json in the PUT call does not contains "is_pool" flag, that looks suspicious. (attaching the wireshark output as screenshot, as the text output from tcpdump is a bit complicated to format)

• Please note that I'm using netbox 3.1.5, not 3.1.3 even though this should have no impact on this behavior, AFAIK.

[fbreckle]

I'm pretty sure that this issue comes from a common problem with the go-netbox library. This happens because, for bool variables, false is not marshalled into JSON if omitempty is set in the struct definition.

This is one of the reasons I maintain my own fork at fbreckle/go-netbox. This has to be fixed there.

[cova-fe]

Will you look at it or should I have a look at the code?

[cova-fe]

I'm pretty sure that this issue comes from a common problem with the go-netbox library. This happens because, for bool variables, false is not marshalled into JSON if omitempty is set in the struct definition.

This is one of the reasons I maintain my own fork at fbreckle/go-netbox. This has to be fixed there.

Could this happen also for other Types? I have to double check, but I suspect that this happens also for (say) vrf_id when from a non-zero value tf wants to change it to 0.

[fbreckle]

Yes, this happens with many optional attributes. Here is my issue in the original go-netbox repo netbox-community/go-netbox#107