Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typescript migration #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

joshuafsharp
Copy link

@joshuafsharp joshuafsharp commented Apr 25, 2023

Wondering if you're keen on getting type safety in this project, as mentioned in the following issue:
#11

I've been working on updates in my fork, so happy to share the changes I've made to use Typescript.
I tried to make the minimal changes possible to add Typescript support, so the functionality should be equivalent to the latest commit on main.

The only other change I made is to simplify the phaser client initialisation with typescript. There's a MainScene class containing all the preload, create and update functions, which is supplied to the Phaser config.

@jit-ci
Copy link

jit-ci bot commented Apr 25, 2023

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@joshuafsharp joshuafsharp changed the title Chore/typescript migration chore: typescript migration Apr 25, 2023
@dzoba
Copy link
Owner

dzoba commented Apr 25, 2023

Thanks for this! I will review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants