Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #15 and #13 #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix for #15 and #13 #16

wants to merge 2 commits into from

Conversation

Juravenator
Copy link

@Juravenator Juravenator commented Jun 16, 2018 •
edited
Loading

These 2 commits fix #15 and #13.
More specifically:

  • The progress calculation logic has been replaced with a scrollTop-based approach, to account for removed calls
    • This logic incidentally makes the progress 100% on small files that don't have a scrollbar
  • The nyancat-view is hidden when no file tabs are opened
  • The nyancat-view creates the DOM only once and updates it, rather than destroy and recreate on every scroll event
  • The nyancat-view takes all available remaining space in the left status bar
  • Replaced the event listener so it also detects scrolling events when the open tab isn't selected (preview tabs)
  • Adjusted the css slightly to fix some unwanted padding

@Juravenator
make it work again with latest atom
83c6381 
- replaced progress calculation logic
  - also makes the progress 100% on files that don't require scrolling
- nyancat-view doesn't destroy and recreate its DOM on every scroll
event
- fixed bug where nyan-view wasn't updated when scrolling in the active
but unselected file
- nyancat-view hides when no files are opened
- fixed unwanted padding in nyan-view
@Juravenator
full width nyan cat
88cda77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nyan cat doesn't seem to grow.
1 participant
@Juravenator