-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/update from template #451
Conversation
* add pre-commit for ruff * add pre commit * add precommit github workflow * update pre-commit version * add pre-commit task * run pre-commit * enable more pre-commit checks * remove black * update pixi.lock * add typo * add precommit to docker * remove black settings * extract ruff settings into ruff.toml * extract ruff settings into ruff.toml * update pre-commit hooks
* add more precommit * fix spelling * pre-commit all
Feature/pre commit
Reviewer's Guide by SourceryThis PR updates the project's development tooling by replacing Black with Ruff for code formatting, adding pre-commit hooks for automated code quality checks, and making various code cleanup changes. The changes primarily focus on modernizing the development workflow and standardizing code formatting. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @blooop - I've reviewed your changes - here's some feedback:
Overall Comments:
- The git config change in update_from_template.sh from local to global (--global) could affect other repositories on the user's system. Consider keeping this as a local config.
- When migrating from black to ruff, ensure all formatting configurations are properly transferred. Consider reviewing the removed black config settings to confirm they're all represented in the new ruff.toml.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 90.48% 90.48%
=======================================
Files 61 61
Lines 3384 3384
=======================================
Hits 3062 3062
Misses 322 322 ☔ View full report in Codecov by Sentry. |
Summary by Sourcery
Integrate pre-commit hooks into the project to automate code quality checks and replace Black with Ruff for code formatting. Update the CI configuration to include a pre-commit workflow that runs on pull requests.
New Features:
Enhancements:
CI: