Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gcp local nvme raid chart #265

Merged
merged 10 commits into from
Jan 16, 2024
Merged

Gcp local nvme raid chart #265

merged 10 commits into from
Jan 16, 2024

Conversation

plejik
Copy link
Contributor

@plejik plejik commented Oct 24, 2023

No description provided.

Copy link
Contributor

@voron voron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good staff.
Could you please take a look on some minor comments, as well as linter issues ?

dysnix/gcp-local-nvme-raid/Chart.yaml Outdated Show resolved Hide resolved
dysnix/gcp-local-nvme-raid/templates/daemonset.yaml Outdated Show resolved Hide resolved
dysnix/gcp-local-nvme-raid/templates/daemonset.yaml Outdated Show resolved Hide resolved
@plejik plejik force-pushed the gcp-local-nvme-raid branch from c186f6d to 23d2aed Compare January 10, 2024 08:54
Copy link
Contributor

@voron voron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes would be nice to have.

dysnix/gcp-local-nvme-raid/Chart.yaml Outdated Show resolved Hide resolved
dysnix/gcp-local-ssd-raid/templates/daemonset.yaml Outdated Show resolved Hide resolved
@voron
Copy link
Contributor

voron commented Jan 15, 2024

@plejik could you pls fix the lint issue and I think we'll be good here.

@plejik plejik merged commit 166509e into main Jan 16, 2024
2 checks passed
@plejik plejik deleted the gcp-local-nvme-raid branch January 16, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants