Broken on 10.9

[tresf]

Testing this library against macOS 10.9, I get the following crash:

2021-01-28 15:37:19.534 java[541:2907] -[NSStatusItem button]: unrecognized selector sent to instance 0x7fb2c1cfb0f0
2021-01-28 15:37:19.535 java[541:2907] An uncaught exception was raised
2021-01-28 15:37:19.536 java[541:2907] -[NSStatusItem button]: unrecognized selector sent to instance 0x7fb2c1cfb0f0
2021-01-28 15:37:19.537 java[541:2907] (
	0   CoreFoundation                      0x00007fff8e140b06 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff8e5553f0 objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff8e1d740a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
	3   CoreFoundation                      0x00007fff8e12f02e ___forwarding___ + 414
	4   CoreFoundation                      0x00007fff8e12ee18 _CF_forwarding_prep_0 + 232
	5   jna286536894285511670.tmp           0x0000000180db5e74 ffi_call_unix64 + 76
	6   ???                                 0x00007fff57e107f8 0x0 + 140734667753464
)
2021-01-28 15:37:19.537 java[541:2907] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '-[NSStatusItem button]: unrecognized selector sent to instance 0x7fb2c1cfb0f0'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007fff8e140b06 __exceptionPreprocess + 198
	1   libobjc.A.dylib                     0x00007fff8e5553f0 objc_exception_throw + 43
	2   CoreFoundation                      0x00007fff8e1d740a -[NSObject(NSObject) doesNotRecognizeSelector:] + 186
	3   CoreFoundation                      0x00007fff8e12f02e ___forwarding___ + 414
	4   CoreFoundation                      0x00007fff8e12ee18 _CF_forwarding_prep_0 + 232
	5   jna286536894285511670.tmp           0x0000000180db5e74 ffi_call_unix64 + 76
	6   ???                                 0x00007fff57e107f8 0x0 + 140734667753464
)

@dyorgio says:

The correct logic is:
if > 10.0 and < 10.10 then access image selector directly on statusitem instance, if >= 10.10 use button as bridge
in fact I believe that accessing image on 10.10 also works, is only deprecated

https://developer.apple.com/documentation/appkit/nsstatusitem/1524711-image?language=objc

[dyorgio]

Please @tresf, can you confirm fix?

[tresf]

I think it will fix it but the version compare isn't working here:

macos-tray-icon-fixer/src/main/java/dyorgio/runtime/macos/trayicon/fixer/MacOSTrayIconFixer.java

Lines 150 to 152 in 09cfc90

	public static boolean isStatusItemButtonSupported() {
	return OS_VERSION.compareTo("10.10") >= 0;
	}

[tresf]

Opened PR here to fix version compare. It's a crude parser, but it should fix the OS detection #4

[tresf]

Closed via 09cfc90 + #4.