Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): use claims and vct instead of credential_definition #211

Merged
merged 9 commits into from
Nov 4, 2024

Conversation

matteo-cristino
Copy link
Collaborator

@matteo-cristino matteo-cristino commented Oct 28, 2024

Also cleanup duplicated code and unnecessary variables and improve checks on input.

This PR points to DIDRoom_microservices fix/claims branch, to be move to main when that PR is merged

@matteo-cristino matteo-cristino marked this pull request as draft October 29, 2024 08:53
@matteo-cristino matteo-cristino changed the title refactor(oauth): cleanup duplicated code and unnecessary variables and improve checks on input fix: use claims and vct instead of credential_definition Nov 4, 2024
@matteo-cristino matteo-cristino changed the title fix: use claims and vct instead of credential_definition fix(oauth): use claims and vct instead of credential_definition Nov 4, 2024
@matteo-cristino matteo-cristino requested a review from puria November 4, 2024 11:09
@matteo-cristino matteo-cristino marked this pull request as ready for review November 4, 2024 11:22
@puria puria merged commit 30fba39 into main Nov 4, 2024
8 checks passed
@puria puria deleted the fix/oauth_redirects_uri branch November 4, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants