Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Clarify that service.* conventions apply to all telemetry sou…
Browse files Browse the repository at this point in the history
…rces (open-telemetry#630)"

This reverts commit 7f35c49.
joaopgrassi committed Jan 12, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent de9ef07 commit 6ddc8a5
Showing 4 changed files with 4 additions and 12 deletions.
3 changes: 0 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -23,9 +23,6 @@ release.

### Fixes

- Clarify that `service.*` attributes apply to all telemetry sources.
([#630](https://github.com/open-telemetry/semantic-conventions/pull/630))

## v1.24.0 (2023-12-15)

### Breaking
4 changes: 2 additions & 2 deletions docs/resource/README.md
Original file line number Diff line number Diff line change
@@ -77,7 +77,7 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet

**type:** `service`

**Description:** A telemetry source. OpenTelemetry has adopted a broad interpretation such that every telemetry source is a service. Examples include, but are not limited to: web services, hosts, mobile applications, browser application, edge computing devices, functions as a service, databases, message brokers, etc. Specific types of telemetry sources may have additional conventions defining domain specific information, but the `service` conventions are applicable to all telemetry sources.
**Description:** A service instance.

<!-- semconv service -->
| Attribute | Type | Description | Examples | Requirement Level |
@@ -94,7 +94,7 @@ as specified in the [Resource SDK specification](https://github.com/open-telemet

**type:** `service`

**Description:** Experimental additions to service.
**Description:** Additions to service instance.

<!-- semconv service_experimental -->
| Attribute | Type | Description | Examples | Requirement Level |
7 changes: 1 addition & 6 deletions model/resource/service.yaml
Original file line number Diff line number Diff line change
@@ -3,12 +3,7 @@ groups:
prefix: service
type: resource
brief: >
A telemetry source. OpenTelemetry has adopted a broad interpretation such that every
telemetry source is a service. Examples include, but are not limited to: web services,
hosts, mobile applications, browser application, edge computing devices, functions as
a service, databases, message brokers, etc. Specific types of telemetry sources may have
additional conventions defining domain specific information, but the `service`
conventions are applicable to all telemetry sources.
A service instance.
attributes:
- id: name
type: string
2 changes: 1 addition & 1 deletion model/resource/service_experimental.yaml
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ groups:
prefix: service
type: resource
brief: >
Experimental additions to service.
A service instance.
attributes:
- id: namespace
type: string

0 comments on commit 6ddc8a5

Please sign in to comment.