Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill customer information and related #19

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

StanislavSmetaninSSM
Copy link
Contributor

  • Refactored code a bit, and moved code related with creation "payment request" to DibsCreateRequestService.
  • Fixed behavior related with "Prefill customer information". Each Consumer object checked for filled information - if something from required information is not set, then we just skip this object and do not send it in the request.
  • All option field in the request were marked as EmitDefaultValue = false, because we don't need to send it if the value is equal to default.
  • Added new setting "Enable billing address", because Dibs supports the billing address information. False by default, customer could activate it if needed.

Original task: https://dev.azure.com/dynamicwebsoftware/Dynamicweb/_workitems/edit/21757

…t request" to DibsCreateRequestService.

- Fixed behavior related with "Prefill customer information". Each Consumer object checked for filled information - if something from required information is not set, then we just skip this object and do not send it in the request.
- All option field in the request were marked as EmitDefaultValue = false, because we don't need to send it if the value is equal to default.
- Added new setting "Enable billing address", because Dibs supports the billing address information. False by default, customer could activate it if needed.
@StanislavSmetaninSSM
Copy link
Contributor Author

Guys, can I merge it?

@StanislavSmetaninSSM StanislavSmetaninSSM merged commit baa15e2 into main Nov 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants