Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove newlines from jupyter math. #63

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Conversation

briandesilva
Copy link
Member

Removed newlines from LaTeX equations in 2_original_paper.ipynb because they create problems when converted to rst for the documentation site. See #62.

@briandesilva briandesilva requested a review from Ohjeah April 8, 2020 01:01
@Ohjeah Ohjeah merged commit 58717d9 into master Apr 8, 2020
@Ohjeah Ohjeah deleted the remove-equation-newlines branch April 8, 2020 07:38
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request Apr 30, 2024
…wlines

Remove newlines from jupyter math.
jpcurbelo pushed a commit to jpcurbelo/pysindy_fork that referenced this pull request May 9, 2024
This commit unifies the way the different models preprocess the static and dynamic input data.

Closes dynamicslab#57 and dynamicslab#74, part of dynamicslab#64.

Similar to the model head, there is now an InputLayer that all (single-frequency) models use. Depending on the config, this layer will:
- pass the static variables through an embedding layer (if cfg.statics_embedding is True)
- pass the dynamic variables through an embedding layer (if cfg.dynamics_embedding is True)
- concatenate static to each step of dynamic inputs (unless this is deactivated; e.g., for EA-LSTM this is not wanted)

Key changes:
- New config arguments statics_embedding, dynamics_embedding (both bool, default False).
- EmbCudaLSTM is no longer needed since the functionality is now part of CudaLSTM. For backwards compatibility, the class still exists but defers to CudaLSTM.
- If EA-LSTM and static embeddings are used, there will now be a linear layer between the embedding output and the lstm input to make sure the dimensions match. Previously, the linear layer would be left out if static embeddings were used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants