-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve type parsing to support arrays and generics #173
Conversation
…on that ensures a nullable type isn't converted to a nullable of nullable. Fixes dynamicexpresso#169
…r parsing of an array of a nullable type (e.g. int?[]).
Thank you @metoule! Are you able to fix the conflicts? (I have merged the other PR...) |
…r parsing of an array of a nullable type (e.g. int?[]).
@davideicardi I've fixed the conflicts :) |
As far as I can tell, this implementation does not support types with a variable amount of generic type parameters?, e.g.
This can be worked-around by naming them Tuple1, Tuple2, etc. |
@Pentiva that's a different issue: the goal of this PR is simply to support parsing generic types in a Your issue is that it's not possible to reference multiple arity of the same generic type name. That's because under the hood there's a dictionary that maps a type name to the actual type, and therefore the last call to Do you mind creating a new issue? |
@metoule I expected as much, just thought I would mention it in this pull request as it is sub-feature of generics and, until this is merged, falls under the adding generics issue. I'll create a new issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Note that I had to remove the token
QuestionDot
andQuestionOpenBracket
, because it prevented the proper parsing ofint?[]
.It's now possible to write:
Fixes #172