Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to specify image transformations #73

Merged
merged 6 commits into from
Oct 26, 2020

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Oct 25, 2020

  • relies on salsify to transform the images

Resolves #36

  - relies on salsify to transform the images
@codecov
Copy link

codecov bot commented Oct 25, 2020

Codecov Report

Merging #73 into master will increase coverage by 1.41%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #73      +/-   ##
============================================
+ Coverage     51.07%   52.49%   +1.41%     
+ Complexity      346      331      -15     
============================================
  Files            19       19              
  Lines           836      823      -13     
============================================
+ Hits            427      432       +5     
+ Misses          409      391      -18     
Flag Coverage Δ Complexity Δ
#php 52.49% <30.76%> (+1.41%) 331.00 <11.00> (-15.00) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/ORM/AssetFormFactoryExtension.php 0.00% <0.00%> (ø) 4.00 <0.00> (ø)
src/TypeHandler/Asset/ImageHandler.php 71.73% <23.07%> (+26.02%) 13.00 <3.00> (-20.00) ⬆️
src/TypeHandler/Asset/AssetHandler.php 54.16% <41.66%> (-3.73%) 16.00 <8.00> (+5.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b628f72...c3ff436. Read the comment docs.

@mak001 mak001 removed the needs docs label Oct 25, 2020
@mak001 mak001 requested review from jsirish and muskie9 October 25, 2020 15:57
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One typo in the readme, and one suggestion for isTransformOutOfDate(). The latter just cuts down on lines and doesn't necessarily have to be implemented.

README.md Outdated Show resolved Hide resolved
src/TypeHandler/Asset/AssetHandler.php Outdated Show resolved Hide resolved
@mak001 mak001 merged commit 0964269 into dynamic:master Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature - Image types should allow transformations
2 participants