Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added class to modification and should skip methods #24

Merged

Conversation

mak001
Copy link
Contributor

@mak001 mak001 commented Nov 14, 2019

Re-organized parameters for handleType methods

Re-organized parameters for handleType methods
@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 70%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #24   +/-   ##
========================================
  Coverage      45.1%   45.1%           
  Complexity      197     197           
========================================
  Files            16      16           
  Lines           501     501           
========================================
  Hits            226     226           
  Misses          275     275
Flag Coverage Δ Complexity Δ
#php 45.1% <70%> (ø) 197 <34> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
src/TypeHandler/LiteralHandler.php 0% <0%> (ø) 1 <1> (ø) ⬇️
src/TypeHandler/Asset/FileHandler.php 0% <0%> (ø) 5 <5> (ø) ⬇️
src/TypeHandler/Relation/ManyHandler.php 0% <0%> (ø) 4 <4> (ø) ⬇️
src/TypeHandler/Relation/HasOneHandler.php 0% <0%> (ø) 5 <5> (ø) ⬇️
src/TypeHandler/RawHandler.php 44.44% <100%> (ø) 5 <5> (ø) ⬇️
src/Model/Mapper.php 88.48% <100%> (ø) 60 <8> (ø) ⬇️
src/TypeHandler/Asset/ImageHandler.php 93.33% <100%> (ø) 8 <6> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32554ee...2536b91. Read the comment docs.

@mak001 mak001 merged commit abadb67 into dynamic:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant