Skip to content

Commit

Permalink
fix: prefix ResponseResultType enum for proto linting (cosmos#1143)
Browse files Browse the repository at this point in the history
damiannolan authored Mar 21, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent dbd2df2 commit 5cf580c
Showing 3 changed files with 93 additions and 93 deletions.
6 changes: 3 additions & 3 deletions docs/ibc/proto-docs.md
Original file line number Diff line number Diff line change
@@ -2048,9 +2048,9 @@ ResponseResultType defines the possible outcomes of the execution of a message

| Name | Number | Description |
| ---- | ------ | ----------- |
| RESPONSE_RESULT_UNSPECIFIED | 0 | Default zero value enumeration |
| RESPONSE_RESULT_NOOP | 1 | The message did not call the IBC application callbacks (because, for example, the packet had already been relayed) |
| RESPONSE_RESULT_SUCCESS | 2 | The message was executed successfully |
| RESPONSE_RESULT_TYPE_UNSPECIFIED | 0 | Default zero value enumeration |
| RESPONSE_RESULT_TYPE_NOOP | 1 | The message did not call the IBC application callbacks (because, for example, the packet had already been relayed) |
| RESPONSE_RESULT_TYPE_SUCCESS | 2 | The message was executed successfully |


<!-- end enums -->
174 changes: 87 additions & 87 deletions modules/core/04-channel/types/tx.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions proto/ibc/core/channel/v1/tx.proto
Original file line number Diff line number Diff line change
@@ -47,11 +47,11 @@ enum ResponseResultType {
option (gogoproto.goproto_enum_prefix) = false;

// Default zero value enumeration
RESPONSE_RESULT_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "UNSPECIFIED"];
RESPONSE_RESULT_TYPE_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "UNSPECIFIED"];
// The message did not call the IBC application callbacks (because, for example, the packet had already been relayed)
RESPONSE_RESULT_NOOP = 1 [(gogoproto.enumvalue_customname) = "NOOP"];
RESPONSE_RESULT_TYPE_NOOP = 1 [(gogoproto.enumvalue_customname) = "NOOP"];
// The message was executed successfully
RESPONSE_RESULT_SUCCESS = 2 [(gogoproto.enumvalue_customname) = "SUCCESS"];
RESPONSE_RESULT_TYPE_SUCCESS = 2 [(gogoproto.enumvalue_customname) = "SUCCESS"];
}

// MsgChannelOpenInit defines an sdk.Msg to initialize a channel handshake. It

0 comments on commit 5cf580c

Please sign in to comment.