feat(app): Upgrading to v50 #1736

mtsitrin · 2025-02-18T17:41:05Z

This PR bumps the dymension repo to use cosmos-sdk v50.x

the main changes besides the straightforward syntax changes:

deprecated the legacytx Msg interface and the deprecated global amino variables
removed deprecated case "/ethermint.types.v1.ExtensionOptionsWeb3Tx" in ante handler

Few technical debts left:

fix streamer UT due to to v50 upgrade #1739
fix liveness UT due to v50 upgrade #1740
Upgrade handler (v47 -> v50)
move msg.ValidateBasic into the message handler #1742

bumped PFM to v8 deprecated usage of /store/types

app/app.go

+	for _, m := range app.mm.Modules {
+		if moduleWithName, ok := m.(module.HasName); ok {
+			moduleName := moduleWithName.Name()
+			if appModule, ok := moduleWithName.(appmodule.AppModule); ok {
+				modules[moduleName] = appModule
+			}
+		}
+	}


app/keepers.go

-		a.AccountKeeper,
-		a.BankKeeper,
-		govModuleAddress,
+		appCodec, runtime.NewKVStoreService(a.keys[stakingtypes.StoreKey]), a.AccountKeeper, a.BankKeeper, authtypes.NewModuleAddress(govtypes.ModuleName).String(), authcodec.NewBech32Codec(appparams.Bech32PrefixValAddr), authcodec.NewBech32Codec(appparams.Bech32PrefixConsAddr),


app/keepers.go

-		a.AccountKeeper,
-		a.BankKeeper,
-		govModuleAddress,
+		appCodec, runtime.NewKVStoreService(a.keys[stakingtypes.StoreKey]), a.AccountKeeper, a.BankKeeper, authtypes.NewModuleAddress(govtypes.ModuleName).String(), authcodec.NewBech32Codec(appparams.Bech32PrefixValAddr), authcodec.NewBech32Codec(appparams.Bech32PrefixConsAddr),


app/params/config.go

@@ -18,26 +21,37 @@
 	BaseDenomUnit = 18

 	AccountAddressPrefix = "dym"
-	Name                 = "dymension"
-)
+	Bech32MainPrefix     = AccountAddressPrefix


app/params/config.go

+	// Bech32PrefixConsAddr defines the Bech32 prefix of a consensus node address
+	Bech32PrefixConsAddr = Bech32MainPrefix + PrefixValidator + PrefixConsensus
+	// Bech32PrefixConsPub defines the Bech32 prefix of a consensus node public key
+	Bech32PrefixConsPub = Bech32MainPrefix + PrefixValidator + PrefixConsensus + PrefixPublic


app/params/config.go

+	// Bech32PrefixConsAddr defines the Bech32 prefix of a consensus node address
+	Bech32PrefixConsAddr = Bech32MainPrefix + PrefixValidator + PrefixConsensus
+	// Bech32PrefixConsPub defines the Bech32 prefix of a consensus node public key
+	Bech32PrefixConsPub = Bech32MainPrefix + PrefixValidator + PrefixConsensus + PrefixPublic


x/sponsorship/keeper/votes.go

x/streamer/module.go

keruch

you can also do make proto-format to reformat all the proto files. and then make proto-gen once again.

* add new update client tx wrapper * maybe were done, expecting import loops * rebuild proto * gonna go back * Revert "gonna go back" This reverts commit 8721196. * move, lets try * need an actual wrapper message * need our own message * regen * test passes * fmt * add a better comment

zale144

wow I didn't know we had so many files in the repo.
nice work, left a few non-critical comments

zale144 · 2025-02-26T15:18:18Z

app/app.go

-		panic("failed to load state streaming services: " + err.Error())
+	// register streaming services
+	if err := bApp.RegisterStreamingServices(appOpts, app.keys); err != nil {
+		panic(err)


panic("failed to load register streaming services: " + err.Error())

zale144 · 2025-02-26T15:20:57Z

app/app.go

-	autocliv1.RegisterQueryServer(app.GRPCQueryRouter(), runtimeservices.NewAutoCLIQueryService(app.mm.Modules))
-
-	reflectionSvc, err := runtimeservices.NewReflectionService()
+	// At startup, after all modules have been registered, check that all prot


Suggested change

// At startup, after all modules have been registered, check that all prot

// At startup, after all modules have been registered, check that all proto

zale144 · 2025-02-26T15:22:13Z

app/app.go

+
+	reflectionSvc, err := runtimeservices.NewReflectionService()
+	if err != nil {
+		panic(err)


add error message

zale144 · 2025-02-26T15:23:03Z

app/app.go

-	app.mm.RegisterServices(app.configurator)
+	err := app.mm.RegisterServices(app.configurator)
+	if err != nil {
+		panic(err)


add error message

zale144 · 2025-02-26T15:50:52Z

app/genesis.go

-// The genesis state of the blockchain is represented here as a map of raw json
-// messages key'd by an identifier string.
+// GenesisState of the blockchain is represented here as a map of raw json
+// messages key'd by a identifier string.


Suggested change

// messages key'd by a identifier string.

// messages key'd by an identifier string.

zale144 · 2025-02-27T17:15:43Z

simulation/types/expected_keepers.go

-	MintCoins(ctx sdk.Context, moduleName string, amt sdk.Coins) error
-	SendCoinsFromModuleToAccount(ctx sdk.Context, senderModule string, recipientAddr sdk.AccAddress, amt sdk.Coins) error
+	SpendableCoins(ctx context.Context, addr sdk.AccAddress) sdk.Coins
+	// MintCoins(ctx context.Context, moduleName string, amt sdk.Coins) error


if not used, better remove

zale144 · 2025-02-27T17:33:07Z

x/dymns/types/proposal.go

+// func init() {
+// 	v1beta1.RegisterProposalType(ProposalTypeMigrateChainIdsProposal)
+// 	govcdc.ModuleCdc.Amino.RegisterConcrete(&MigrateChainIdsProposal{}, "dymns/"+ProposalTypeMigrateChainIdsProposal, nil)

-	v1beta1.RegisterProposalType(ProposalTypeUpdateAliasesProposal)
-	govcdc.ModuleCdc.Amino.RegisterConcrete(&UpdateAliasesProposal{}, "dymns/"+ProposalTypeUpdateAliasesProposal, nil)
-}
+// 	v1beta1.RegisterProposalType(ProposalTypeUpdateAliasesProposal)
+// 	govcdc.ModuleCdc.Amino.RegisterConcrete(&UpdateAliasesProposal{}, "dymns/"+ProposalTypeUpdateAliasesProposal, nil)
+// }


if not used, better remove

zale144 · 2025-02-27T17:45:58Z

x/sponsorship/module.go

-	_ module.HasGenesis    = AppModule{}
-	_ module.HasInvariants = AppModule{}
-)
+// _ module.HasGenesis    = AppModule{}


not needed?

zale144 · 2025-02-27T17:47:34Z

x/streamer/module.go

+	// _ module.AppModuleSimulation = AppModule{}
+	// _ module.HasGenesis          = AppModule{}


not needed?

mtsitrin added 30 commits January 14, 2025 14:13

bumped ibc to v8

7cf53ae

bumped PFM to v8 deprecated usage of /store/types

go mod tidy passes

53ea151

more deps. log and db

f9a7c2f

updating math dep

0439798

updating keepers

9d3eb5f

updated expected keepers

85d051e

cleared some codecs

2553c17

updated math

98026ba

updated dymns

cdf62d7

semi handled eibc

278cbb1

updated module.go files

82e6f4d

more support

e08f28c

done with streamer

14c25a6

sponsorship

e8dc18a

cleaned legacyTx

fc6a13b

rollapp cleanup

c139df4

cleanip

3babcfd

removed unneeded deps

a7f6e52

disabled eth ante handlers

7f5ba05

fixed modules setup

4b53251

app WIP

5881dbf

keepers pass

5fe77f7

app pass

2526ed1

updated proto files

36df3fe

generated proto files

4700e6c

updated half modules

a1a656e

updated modules part 2

6a0bde1

handled dymd command:

639d88e

ante handler WIP

e994396

fixed minor in modules

fcb16a0

mtsitrin added 13 commits February 16, 2025 13:01

go.mod

d0cc9bc

fixed IBC light client initialization

82c8e94

fixed coinbase bug

e62c6ae

ibcetesting pass

dddaa60

fixing modules UT

12c2b5b

fixing tests

9f7ce56

fixing more UT

2390a85

fixed dymns UT

c2947e5

fixed dym to adym denom

bb71530

wip

6e1f9e7

wip streamer UT

90e409a

disabled broken tests

429095b

Merge branch 'main' into upgrading_to_v50

aa4b23a

github-actions bot added the dym-internal label Feb 19, 2025

github-advanced-security bot found potential problems Feb 19, 2025

View reviewed changes

mtsitrin added 3 commits February 19, 2025 11:48

cleanup

df6d2e8

more cleanup

1b191f5

minor fix

8099a3f

mtsitrin marked this pull request as ready for review February 19, 2025 10:10

mtsitrin requested a review from a team as a code owner February 19, 2025 10:10

mtsitrin added 2 commits February 19, 2025 13:11

linter

d7fbcb9

linter fix

f28df2f

keruch reviewed Feb 21, 2025

View reviewed changes

mtsitrin added 2 commits February 23, 2025 10:55

merge main

87069fe

Merge branch 'main' into upgrading_to_v50

c54f6a3

omritoptix assigned zale144 Feb 26, 2025

zale144 previously approved these changes Feb 27, 2025

View reviewed changes

fixed CLI for legacy proposals

87d979d

mtsitrin dismissed zale144’s stale review via 87d979d March 3, 2025 10:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(app): Upgrading to v50 #1736

feat(app): Upgrading to v50 #1736

mtsitrin commented Feb 18, 2025 •

edited

Loading

keruch left a comment

zale144 left a comment

zale144 Feb 26, 2025

zale144 Feb 26, 2025

zale144 Feb 26, 2025

zale144 Feb 26, 2025

zale144 Feb 26, 2025

zale144 Feb 27, 2025

zale144 Feb 27, 2025

zale144 Feb 27, 2025

zale144 Feb 27, 2025

	// At startup, after all modules have been registered, check that all prot
	// At startup, after all modules have been registered, check that all proto

	// messages key'd by a identifier string.
	// messages key'd by an identifier string.

		// _ module.AppModuleSimulation = AppModule{}
		// _ module.HasGenesis = AppModule{}

feat(app): Upgrading to v50 #1736

Are you sure you want to change the base?

feat(app): Upgrading to v50 #1736

Conversation

mtsitrin commented Feb 18, 2025 • edited Loading

keruch left a comment

Choose a reason for hiding this comment

zale144 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtsitrin commented Feb 18, 2025 •

edited

Loading