Danwt/research 441 sketch genesis simulation tx #1549
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwt
commented
Nov 25, 2024
Comment on lines
+15
to
+20
| type validator struct { | ||
| rollapp GenesisBridgeData // what the rollapp sent over IBC | ||
| hub types.GenesisInfo // what the rollapp thinks is correct | ||
| channelID string // can use "channel-0" in simulation | ||
| rollappID string // the actual rollapp ID | ||
| } |
There was a problem hiding this comment.
This will do as much validation as I think is practical
danwt
commented
Nov 25, 2024
Comment on lines
-117
to
118
| err = w.ValidateGenesisBridge(ra, genesisBridgeData.GenesisInfo) | ||
| actionItems, err := v.validateAndGetActionItems() | ||
| if err != nil { | ||
| l.Error("Validate genesis info.", "err", err) | ||
| return uevent.NewErrorAcknowledgement(ctx, errorsmod.Wrap(err, "validate genesis info")) | ||
| return uevent.NewErrorAcknowledgement(ctx, errorsmod.Wrap(err, "validate and get actionable data")) | ||
| } |
There was a problem hiding this comment.
this does the bulk of validation
danwt
commented
Nov 25, 2024
Comment on lines
120
to
132
| w.transferKeeper.SetDenomTrace(ctx, actionItems.trace) | ||
| if err := w.denomKeeper.CreateDenomMetadata(ctx, actionItems.bankMeta); err != nil { | ||
| return uevent.NewErrorAcknowledgement(ctx, errorsmod.Wrap(err, "create denom metadata")) | ||
| } | ||
|
|
||
| // validate and handle the genesis transfer | ||
| err = w.handleGenesisTransfer(ctx, *ra, packet, genesisBridgeData.GenesisTransfer) | ||
| if err != nil { | ||
| l.Error("Handle genesis transfer.", "err", err) | ||
| if err := w.transferKeeper.OnRecvPacket(ctx, packet, actionItems.fungiDatas[0]); err != nil { | ||
| return uevent.NewErrorAcknowledgement(ctx, errorsmod.Wrap(err, "handle genesis transfer")) | ||
| } | ||
| for _, data := range actionItems.fungiDatas { | ||
| if err := w.transferKeeper.OnRecvPacket(ctx, packet, data); err != nil { | ||
| return uevent.NewErrorAcknowledgement(ctx, errorsmod.Wrap(err, "handle genesis transfer")) | ||
| } | ||
| } |
There was a problem hiding this comment.
Here, we still have three points of failure, even after validation
- Set denom trace in transfer keeper
- Recv the packet(s) downstream
- Create the metadata in denom keeper
It would be hard to simulate these because they need the real channel and packet. But given that we do so much validation beforehand, it might be a good practical solution
danwt
commented
Nov 25, 2024
| } | ||
|
|
||
| // validate genesis info against the expected data set on the rollapp | ||
| err = w.ValidateGenesisBridge(ra, genesisBridgeData.GenesisInfo) | ||
| actionItems, err := v.validateAndGetActionItems() |
There was a problem hiding this comment.
We call this in two places
- In a query that dymint will call
- here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
For Reviewer:
After reviewer approval: