Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support D2 and convert to mono-repo (closes #133) #134

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dylanowen
Copy link
Owner

No description provided.

@dylanowen dylanowen linked an issue May 28, 2024 that may be closed by this pull request
}

result, err := json.Marshal(value)
//result, err := json.MarshalIndent(value, "", " ")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code?

}
}

// #[cfg(test)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code? Can we keep the tests?

Copy link
Collaborator

@Cypher1 Cypher1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some of it reviewed but I think we're losing test cases and just noticed it's WIP still, there's some todo/wip feedback and I'll leave it be :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding additional code->svg tools
2 participants