This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
fixed bug that overwrites saved stty settings #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce the bug, start shfm, resize your terminal to trigger SIGWINCH's trap, then exit shfm. You'll notice that icanon and echo are disabled even though term_reset should've reset those. At program start, stty is saved so that it can be restored at exit. SIGWINCH's trap calls term_setup which overwrites stty unnecessarily. I moved stty set out of term_setup to avoid this.