fix: set delegate after successful registration (open-telemetry#105)

Set the new TracerProvider as delegate in ProxyTracerProvider only if global registration was successful.
dyladan · Jul 27, 2021 · 4711f90 · 4711f90
1 parent 89f2f6b
commit 4711f90
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/api/src/api/trace.ts b/api/src/api/trace.ts
@@ -63,12 +63,15 @@ export class TraceAPI {
    * @returns true if the tracer provider was successfully registered, else false
    */
   public setGlobalTracerProvider(provider: TracerProvider): boolean {
-    this._proxyTracerProvider.setDelegate(provider);
-    return registerGlobal(
+    const success = registerGlobal(
       API_NAME,
       this._proxyTracerProvider,
       DiagAPI.instance()
     );
+    if (success) {
+      this._proxyTracerProvider.setDelegate(provider);
+    }
+    return success;
   }
 
   /**

diff --git a/api/test/api/api.test.ts b/api/test/api/api.test.ts
@@ -93,6 +93,18 @@ describe('API', () => {
       assert.deepStrictEqual(span, dummySpan);
     });
 
+    it('should set delegate only on success', () => {
+      assert.strictEqual(
+        api.trace.setGlobalTracerProvider(new TestTracerProvider()),
+        true
+      );
+      assert.strictEqual(
+        api.trace.setGlobalTracerProvider(new NoopTracerProvider()),
+        false
+      );
+      assert.ok(api.trace.getTracer('name') instanceof TestTracer);
+    });
+
     class TestTracer extends NoopTracer {
       override startSpan(name: string, options?: SpanOptions): Span {
         return dummySpan;