-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include .pyi files in v4-proto-py build #521
Conversation
WalkthroughThis change set enhances the build process by updating import statements for protobuf-generated files and ensuring all necessary files are included during package installation. It modifies the Perl command in the makefile, updates the MANIFEST.in file, and adjusts the setup configuration. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (3)
- Makefile (1 hunks)
- v4-proto-py/MANIFEST.in (1 hunks)
- v4-proto-py/setup.py (1 hunks)
Files skipped from review due to trivial changes (2)
- v4-proto-py/MANIFEST.in
- v4-proto-py/setup.py
Additional comments (Suppressed): 1
Makefile (1)
- 43-43: The Perl command has been updated to include two new file patterns ('_pb2.pyi' and '_pb2_grpc.pyi'). This ensures that these additional file types have their import statements correctly updated. Make sure that the regex pattern used in the Perl command is compatible with these new file types.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean the pyi files were generated already, just not included in the package?
Yes thats correct |
Summary by CodeRabbit
*_pb2.pyi
and*_pb2_grpc.pyi
). This ensures correct import statements in these files.v4-proto-py/MANIFEST.in
to include all*.pyi
files recursively, ensuring they are packaged during distribution.v4-proto-py/setup.py
to include package data during installation. This guarantees that all necessary files specified in the MANIFEST.in file are included when the package is installed.