Remove unused line in transfer controller

[teddyding]

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Simplified logic for categorizing transfer types based on sender and recipient subaccount information.

• Bug Fixes

  • Improved response structure for transfers involving parent subaccounts.

[coderabbitai]

Walkthrough

The changes in this pull request involve a modification to the transferToParentSubaccountResponseObject function within the request-transformer.ts file. The update simplifies the logic for determining the transferType by removing a conditional check related to the recipientParentSubaccountNum. The new implementation assigns the transferType based on the presence of the senderSubaccountId and whether the senderAddress matches the provided address. This change streamlines how transfers are categorized, particularly concerning parent subaccounts.

Changes

File Path	Change Summary
indexer/services/comlink/src/request-helpers/request-transformer.ts	Modified transferToParentSubaccountResponseObject function to simplify transferType assignment logic. Removed conditional check for recipientParentSubaccountNum.

Possibly related PRs

• fix transfers parent SA API for external addresses in transfers #2630: This PR modifies the filtering logic for transfers involving parent subaccounts, which is directly related to the changes made in the transferToParentSubaccountResponseObject function in the main PR, as both involve the handling of transfer types based on sender and recipient information.

🐰 In the land of code where changes bloom,
A function transformed, dispelling the gloom.
No more checks, just a clear, bright way,
Transfers now dance, come what may!
With types simplified, let the logic flow,
Hooray for the changes, let the transfers glow! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between fc5ff36 and b85694a.

📒 Files selected for processing (1)

• indexer/services/comlink/src/request-helpers/request-transformer.ts (1 hunks)

🔇 Additional comments (1)

indexer/services/comlink/src/request-helpers/request-transformer.ts (1)

Line range hint 273-279: LGTM! Consider removing unused variable calculation

The transfer type determination logic has been correctly simplified. However, recipientParentSubaccountNum is calculated earlier in the function but is no longer used in the logic after this change.

Consider removing the unused calculation:

-  const recipientParentSubaccountNum = transfer.recipientWalletAddress
-    ? undefined
-    : parentSubaccountHelpers.getParentSubaccountNum(
-      subaccountMap[transfer.recipientSubaccountId!].subaccountNumber,
-    );

Note: Only remove if recipientParentSubaccountNum is not used elsewhere in the response object construction.

Let's verify if recipientParentSubaccountNum is used elsewhere in the response object:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.