fix(affiliates): Fix logic in affiliate referred volume aggregation (backport #2623) #2624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist
Currently, when calculating referred volumes from new fills, if the taker is not referred, the fill is skipped directly so the maker volume (even if referred) does not count towards the affiliate's referred volume.
Fixed by independently adding volume from taker/maker.
This bug may result in protocol-view of affiliate referred volume being smaller than actual, potentially leading to lower than expected affiliate tier.
Test Plan
Unit test
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
New Features
Bug Fixes
This is an automatic backport of pull request #2623 done by [Mergify](https://mergify.com).