Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove megavault subaccount from sample pregenesis #2467

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

tqin7
Copy link
Contributor

@tqin7 tqin7 commented Oct 3, 2024

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

  • If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
  • If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
  • If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
  • If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
  • If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
  • Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

  • New Features

    • Simplified initial state of the blockchain application by removing the subaccounts section, indicating no subaccounts are initialized.
    • Enhanced application state with detailed configurations for various modules, including auth, bank, clob, bridge, and perpetuals.
    • Introduced comprehensive market configurations for trading and liquidity provision.
  • Bug Fixes

    • Ensured continuity in the blockchain's identity and timing by retaining essential fields like genesis_time and chain_id.

@tqin7 tqin7 requested a review from a team as a code owner October 3, 2024 21:44
Copy link
Contributor

coderabbitai bot commented Oct 3, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The changes involve a significant update to the sample_pregenesis.json file used in a blockchain application. The primary modification is the removal of the subaccounts section, which has been replaced with an empty array, indicating no initialized subaccounts. The app_state section has been extensively detailed with various parameters for modules like auth, bank, clob, bridge, and perpetuals. The marketmap section has been populated with market configurations, while the params section specifies operational parameters.

Changes

File Change Summary
protocol/scripts/genesis/sample_pregenesis.json Removed the subaccounts section, replaced with an empty array; detailed modifications to app_state, marketmap, and params sections.

Possibly related PRs

  • Update large cap params in genesis #2431: This PR updates parameters in the sample_pregenesis.json file, which is directly related to the changes made in the main PR that also modifies this file by removing the subaccounts section.

Suggested labels

proto

Suggested reviewers

  • vincentwschau

Poem

In the realm of chains where rabbits play,
Subaccounts have hopped away! 🐇
With a simple state, we now begin,
A fresh new start, let the fun spin!
Assets and banks, all in a row,
Let's build a world where bunnies glow! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tqin7 tqin7 merged commit eefff67 into main Oct 3, 2024
15 checks passed
@tqin7 tqin7 deleted the tq/fix-sample-pregenesis branch October 3, 2024 21:45
@tqin7
Copy link
Contributor Author

tqin7 commented Oct 3, 2024

@Mergifyio backport release/protocol/v7.x

Copy link
Contributor

mergify bot commented Oct 3, 2024

backport release/protocol/v7.x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants