in testing, megavault main subaccount has 0 usdc by default

[tqin7]

Changelist

[Describe or list the changes made in this PR]

Test Plan

[Describe how this PR was tested (if applicable)]

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Introduced a testing environment with updated market configurations and liquidity tiers.
  • Added new market pairs and parameters for assets like BTC, ETH, and LINK.

• Bug Fixes

  • Adjusted the initial balance for the main vault to zero for accurate testing.

• Documentation

  • Updated genesis configuration to reflect new parameters and settings for improved clarity.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve significant modifications to the genesis.sh script, which configures the initial state of a blockchain environment. Key updates include setting the DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE to zero, adding a new variable GENESIS_TIME, and adjusting market configurations for various assets. These modifications ensure that the blockchain's state is correctly initialized for testing, with specific parameters for market operations, liquidity management, and account balances.

Changes

File	Change Summary
protocol/testing/genesis.sh	- Updated DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE from 1000000000000 to 0. - Added GENESIS_TIME set to "2023-01-01T00:00:00Z". - Modified market configurations, including new market pairs and liquidity tiers. - Adjusted parameters for the prices module and exchange configurations for assets like BTC, ETH, and LINK.

Possibly related PRs

• [TRA-451] initialize vaults on start-up in local, dev, staging #1782: This PR modifies the genesis.sh script to include functionality related to vault accounts, which is directly relevant to the changes made in the main PR regarding vault configurations.
• fix TEST-USD marketmap genesis #2066: This PR also updates the genesis.sh script, specifically modifying market configurations, which aligns with the changes in the main PR that involve market parameters and configurations.
• Update large cap params in genesis #2431: This PR updates parameters in the genesis.sh file, which is directly related to the comprehensive changes made in the main PR regarding the genesis configuration for the blockchain environment.

Suggested labels

protocol

Suggested reviewers

• vincentwschau

🐰 In the land of blocks and chains,
Where vaults and markets play their games,
A balance set to zero now,
New time and pairs, we take a bow!
With every change, the future gleams,
In testing realms, we chase our dreams! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 161c34d and 64f6adc.

📒 Files selected for processing (1)

• protocol/testing/genesis.sh (1 hunks)

🔇 Additional comments (2)

protocol/testing/genesis.sh (2)

26-26: Verify zero balance for DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE

Setting DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE to 0 initializes the Megavault main vault with zero USDC balance. Please confirm that this is the intended behavior and that no functionalities depend on a non-zero initial balance. Ensure that tests and scripts that rely on this value are updated accordingly.

To verify that no code assumes a non-zero balance for DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE, run the following script:

✅ Verification successful

Verification Successful: DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE is correctly set to zero and handled appropriately.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for usages of DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE and check for assumptions of non-zero values.

# Test: Find code where DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE is used. Expect: No hard-coded assumptions of non-zero values.
rg 'DEFAULT_MEGAVAULT_MAIN_VAULT_QUOTE_BALANCE' -A 5 -B 5

Length of output: 2047

---

Line range hint 72-72: Confirm the use of a fixed past GENESIS_TIME

Setting GENESIS_TIME to "2023-01-01T00:00:00Z" sets the genesis time to a fixed date in the past. Please confirm that this is intentional and appropriate for the testing environment. Verify that this does not cause issues with consensus mechanisms, block times, or any time-dependent functionalities within the network.

To ensure that using a past GENESIS_TIME does not introduce issues, consider running the following script:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[tqin7]

@Mergifyio backport release/protocol/v7.x

[mergify]

backport release/protocol/v7.x

✅ Backports have been created

• #2463 in testing, megavault main subaccount has 0 usdc by default (backport #2462) has been created for branch release/protocol/v7.x