-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix vulcan post processing metrics not emitted for short term orders #2244
Conversation
WalkthroughThe changes in this pull request modify the condition for checking the existence of a timestamp in the Changes
Poem
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@@ -122,7 +122,7 @@ export async function onMessage(message: KafkaMessage): Promise<void> { | |||
await handler.handleUpdate(update, headers); | |||
|
|||
const postProcessingTime: number = Date.now(); | |||
if (originalMessageTimestamp !== undefined) { | |||
if (headers.message_received_timestamp !== undefined) { | |||
stats.timing( | |||
`${config.SERVICE_NAME}.message_time_since_received_post_processing`, | |||
postProcessingTime - Number(originalMessageTimestamp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message_received_timestamp
04224e7
to
bdc4ea7
Compare
@Mergifyio backport release/indexer/v6.x |
https://github.com/Mergifyio backport release/indexer/v5.x |
✅ Backports have been created
|
✅ Backports have been created
|
…(backport #2244) (#2245) Co-authored-by: roy-dydx <[email protected]>
…(backport #2244) (#2246) Co-authored-by: roy-dydx <[email protected]>
Changelist
Stale variable was used causing these metrics not to appear.
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breaking
label.indexer-postgres-breaking
label.PrepareProposal
orProcessProposal
, manually add the labelproposal-breaking
.feature:[feature-name]
.backport/[branch-name]
.refactor
,chore
,bug
.Summary by CodeRabbit
Bug Fixes
Chores