[CT-968] Fix snapshot validation by including subaccounts from proposed operation queue

[dydxwill]

Changelist

Fix subaccount update validation

Test Plan

Tested in dev

Author/Reviewer Checklist

• If this PR has changes that result in a different app state given the same prior state and transaction list, manually add the state-breaking label.
• If the PR has breaking postgres changes to the indexer add the indexer-postgres-breaking label.
• If this PR isn't state-breaking but has changes that modify behavior in PrepareProposal or ProcessProposal, manually add the label proposal-breaking.
• If this PR is one of many that implement a specific feature, manually label them all feature:[feature-name].
• If you wish to for mergify-bot to automatically create a PR to backport your change to a release branch, manually add the label backport/[branch-name].
• Manually add any of the following labels: refactor, chore, bug.

Summary by CodeRabbit

• New Features

  • Expanded GitHub Actions workflows to trigger on an additional branch for improved integration and deployment scenarios.
  • Enhanced operation processing by merging subaccount IDs from both proposed and local validator operations for better responsiveness.

• Bug Fixes

  • Improved handling of subaccount updates, ensuring all relevant IDs are considered.

[coderabbitai]

Walkthrough

The changes introduce a new branch trigger in two GitHub Actions workflows to activate on pushes to 'wl/dbg_su', expanding the execution conditions for both workflows. Additionally, the ProcessProposerOperations function in process_operations.go has been modified to retrieve subaccount IDs from both proposed operations and local validator operations, improving the function’s capability to manage updates.

Changes

File	Change Summary
.github/workflows/.../indexer-build-and-push-dev-staging.yml .github/workflows/.../protocol-build-and-push.yml	Added branch 'wl/dbg_su' to trigger workflows on push events.
protocol/x/clob/keeper/.../process_operations.go	Modified ProcessProposerOperations to fetch subaccount IDs from both proposed and local validator operations, merging them for updates.

Poem

🐇 In a world of code, I hop and play,
New triggers and functions brighten the day.
Subaccounts align, like stars in the night,
With changes so clever, everything’s right!
So here’s to the updates, let’s give them a cheer,
A rabbit's delight in the code we hold dear! 🐾

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 14393e4 and d33505c.

Files selected for processing (2)

• .github/workflows/indexer-build-and-push-dev-staging.yml (1 hunks)
• protocol/x/clob/keeper/process_operations.go (1 hunks)

Additional comments not posted (2)

.github/workflows/indexer-build-and-push-dev-staging.yml (1)

6-6: LGTM! The branch trigger addition is correct.

The addition of the 'wl/dbg_su' branch to the workflow triggers is appropriate and expands the workflow's execution conditions without affecting existing functionality.

protocol/x/clob/keeper/process_operations.go (1)

98-105: LGTM! The subaccount ID fetching logic is enhanced.

The changes to fetch subaccount IDs from both proposed operations and local validator operations improve the function's responsiveness to subaccount state changes. The merging of ID sets is correctly implemented.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d33505c and e3add87.

Files selected for processing (1)

• .github/workflows/protocol-build-and-push.yml (1 hunks)

Additional comments not posted (1)

.github/workflows/protocol-build-and-push.yml (1)

6-6: Branch trigger addition is correct.

The addition of the 'wl/dbg_su' branch to the list of branches that trigger the workflow on push events is consistent with the existing configuration.

[linear]

CT-968 Positions - Test correctness