-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adam/add candles hloc (backport #2047) #2134
Adam/add candles hloc (backport #2047) #2134
Conversation
(cherry picked from commit 73b04dc) # Conflicts: # indexer/packages/postgres/src/db/migrations/migration_files/20240627152937_candles_add_mid_book_price_open_and_close.ts # indexer/packages/redis/__tests__/caches/orderbook-levels-cache.test.ts # indexer/packages/redis/src/caches/orderbook-levels-cache.ts # indexer/services/ender/src/lib/candles-generator.ts
Cherry-pick of 73b04dc has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Changelist
Re-add orderbookMidPriceOpen and Close to candles table
Test Plan
Tested manually in Dev environments
Summary by CodeRabbit
New Features
orderbookMidPriceOpen
andorderbookMidPriceClose
properties to various models and API documentation, improving market data representation.Bug Fixes
Tests
getOrderBookMidPrice
, validating edge cases and mid-price calculations.Documentation
This is an automatic backport of pull request #2047 done by [Mergify](https://mergify.com).