Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adam/add candles hloc (backport #2047) #2134

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 21, 2024

Changelist

Re-add orderbookMidPriceOpen and Close to candles table

Test Plan

Tested manually in Dev environments

Summary by CodeRabbit

  • New Features

    • Introduced new branch trigger for GitHub Actions, enhancing workflow responsiveness.
    • Added orderbookMidPriceOpen and orderbookMidPriceClose properties to various models and API documentation, improving market data representation.
  • Bug Fixes

    • Enhanced candle generation process by integrating order book mid prices, ensuring accurate financial data management.
  • Tests

    • Added comprehensive test suite for getOrderBookMidPrice, validating edge cases and mid-price calculations.
  • Documentation

    • Updated API documentation and Swagger schema to include new mid-price fields for better client insights.

This is an automatic backport of pull request #2047 done by [Mergify](https://mergify.com).

(cherry picked from commit 73b04dc)

# Conflicts:
#	indexer/packages/postgres/src/db/migrations/migration_files/20240627152937_candles_add_mid_book_price_open_and_close.ts
#	indexer/packages/redis/__tests__/caches/orderbook-levels-cache.test.ts
#	indexer/packages/redis/src/caches/orderbook-levels-cache.ts
#	indexer/services/ender/src/lib/candles-generator.ts
Copy link
Contributor Author

mergify bot commented Aug 21, 2024

Cherry-pick of 73b04dc has failed:

On branch mergify/bp/release/indexer/v6.x/pr-2047
Your branch is up to date with 'origin/release/indexer/v6.x'.

You are currently cherry-picking commit 73b04dc3.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both added:      indexer/packages/postgres/src/db/migrations/migration_files/20240627152937_candles_add_mid_book_price_open_and_close.ts
	both modified:   indexer/packages/redis/__tests__/caches/orderbook-levels-cache.test.ts
	both modified:   indexer/packages/redis/src/caches/orderbook-levels-cache.ts
	both modified:   indexer/services/ender/src/lib/candles-generator.ts

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot mentioned this pull request Aug 21, 2024
Copy link
Contributor

coderabbitai bot commented Aug 21, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@adamfraser adamfraser merged commit 82c72c5 into release/indexer/v6.x Aug 21, 2024
15 checks passed
@adamfraser adamfraser deleted the mergify/bp/release/indexer/v6.x/pr-2047 branch August 21, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants