Update mainnet and testnet images for v6.0.0 development #2053
Conversation
WalkthroughThe recent changes involve updating version references in several shell scripts related to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- protocol/testing/mainnet/mainnet.sh (1 hunks)
- protocol/testing/mainnet/vars.sh (1 hunks)
- protocol/testing/testnet/testnet.sh (1 hunks)
- protocol/testing/testnet/vars.sh (1 hunks)
Files skipped from review due to trivial changes (2)
- protocol/testing/mainnet/mainnet.sh
- protocol/testing/testnet/testnet.sh
Additional context used
Shellcheck
protocol/testing/mainnet/vars.sh
[warning] 4-4: CURRENT_VERSION_DIR appears unused. Verify use (or export if used externally).
(SC2034)
protocol/testing/testnet/vars.sh
[warning] 4-4: CURRENT_VERSION_DIR appears unused. Verify use (or export if used externally).
(SC2034)
Additional comments not posted (2)
protocol/testing/mainnet/vars.sh (1)
4-4: Verify usage ofCURRENT_VERSION_DIR.The variable
CURRENT_VERSION_DIRis updated to"v6.0.0", but it appears unused within this script. Ensure that it is used elsewhere or consider exporting it if needed.Verification successful
CURRENT_VERSION_DIRis used in other scripts.The variable
CURRENT_VERSION_DIRis indeed used in other scripts within the codebase. It is referenced in bothtestnet.shandmainnet.shscripts to construct the path forcurrent_version_path. Thus, the update to"v6.0.0"is valid and utilized.
protocol/testing/testnet/testnet.shprotocol/testing/mainnet/mainnet.shScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `CURRENT_VERSION_DIR` in the codebase. # Test: Search for the usage of `CURRENT_VERSION_DIR`. Expect: Occurrences of the variable in other scripts or files. rg --type shell 'CURRENT_VERSION_DIR'Length of output: 67
Script:
#!/bin/bash # Description: Verify the usage of `CURRENT_VERSION_DIR` in the codebase. # Test: Search for the usage of `CURRENT_VERSION_DIR` in all files. rg 'CURRENT_VERSION_DIR'Length of output: 376
Tools
Shellcheck
[warning] 4-4: CURRENT_VERSION_DIR appears unused. Verify use (or export if used externally).
(SC2034)
protocol/testing/testnet/vars.sh (1)
4-4: Verify usage ofCURRENT_VERSION_DIR.The variable
CURRENT_VERSION_DIRis updated to"v6.0.0", but it appears unused within this script. Ensure that it is used elsewhere or consider exporting it if needed.Verification successful
"""
"""
CURRENT_VERSION_DIRis used in other scripts.The variable
CURRENT_VERSION_DIRis indeed used in other parts of the codebase, specifically in thetestnet.shandmainnet.shscripts. This confirms that the variable is not unused and plays a role in setting thecurrent_version_path.
protocol/testing/testnet/testnet.sh: Used to construct thecurrent_version_path.protocol/testing/mainnet/mainnet.sh: Similarly used to construct thecurrent_version_path.No changes are needed regarding the usage of this variable.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `CURRENT_VERSION_DIR` in the codebase. # Test: Search for the usage of `CURRENT_VERSION_DIR`. Expect: Occurrences of the variable in other scripts or files. rg --type shell 'CURRENT_VERSION_DIR'Length of output: 67
Script:
#!/bin/bash # Corrected command to search for the usage of `CURRENT_VERSION_DIR` in the codebase. rg 'CURRENT_VERSION_DIR'Length of output: 376
Tools
Shellcheck
[warning] 4-4: CURRENT_VERSION_DIR appears unused. Verify use (or export if used externally).
(SC2034)
|
https://github.com/Mergifyio backport release/protocol/v6.x |
✅ Backports have been created
|
(cherry picked from commit 6f39469)
) (#2056) Co-authored-by: roy-dydx <[email protected]>
Changelist
Images include previous version v5.2.0 and current commit as v6.0.0
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
New Features
Bug Fixes