comments

dydxprotocol · Sep 16, 2024 · ac7224a · ac7224a
1 parent d9c2ef5
commit ac7224a
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/protocol/streaming/full_node_streaming_manager.go b/protocol/streaming/full_node_streaming_manager.go
@@ -840,7 +840,12 @@ func (sm *FullNodeStreamingManagerImpl) GetSubaccountSnapshotsForInitStreams(
 	return ret
 }
 
-func (sm *FullNodeStreamingManagerImpl) addBatchUpdatesToCache(
+// addBatchUpdatesToCacheWithLock adds batched updates to the cache.
+// Used by `StreamBatchUpdatesAfterFinalizeBlock` to batch orderbook, fill
+// and subaccount updates in a single stream.
+// Note this method requires the lock and assumes that the lock has already been
+// acquired by the caller.
+func (sm *FullNodeStreamingManagerImpl) addBatchUpdatesToCacheWithLock(
 	orderbookStreamUpdates []clobtypes.StreamUpdate,
 	orderbookClobPairIds []uint32,
 	fillStreamUpdates []clobtypes.StreamUpdate,
@@ -911,7 +916,7 @@ func (sm *FullNodeStreamingManagerImpl) StreamBatchUpdatesAfterFinalizeBlock(
 	// Flush all pending updates, since we want the onchain updates to arrive in a batch.
 	sm.FlushStreamUpdatesWithLock()
 
-	sm.addBatchUpdatesToCache(
+	sm.addBatchUpdatesToCacheWithLock(
 		orderbookStreamUpdates,
 		orderbookClobPairIds,
 		fillStreamUpdates,