Bump grpc stream flag default values (#2051)

dydxprotocol · Aug 15, 2024 · a7d0270 · a7d0270
1 parent 73d39d3
commit a7d0270
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go
@@ -59,8 +59,8 @@ const (
 
 	DefaultGrpcStreamingEnabled              = false
 	DefaultGrpcStreamingFlushIntervalMs      = 50
-	DefaultGrpcStreamingMaxBatchSize         = 2000
-	DefaultGrpcStreamingMaxChannelBufferSize = 2000
+	DefaultGrpcStreamingMaxBatchSize         = 1000000
+	DefaultGrpcStreamingMaxChannelBufferSize = 1000000
 
 	DefaultVEOracleEnabled = true
 )

diff --git a/protocol/app/flags/flags_test.go b/protocol/app/flags/flags_test.go
@@ -76,8 +76,8 @@ func TestValidate(t *testing.T) {
 				GrpcEnable:                        true,
 				GrpcStreamingEnabled:              true,
 				GrpcStreamingFlushIntervalMs:      100,
-				GrpcStreamingMaxBatchSize:         2000,
-				GrpcStreamingMaxChannelBufferSize: 2000,
+				GrpcStreamingMaxBatchSize:         1000000,
+				GrpcStreamingMaxChannelBufferSize: 1000000,
 			},
 		},
 		"failure - gRPC disabled": {
@@ -110,7 +110,7 @@ func TestValidate(t *testing.T) {
 				GrpcEnable:                   true,
 				GrpcStreamingEnabled:         true,
 				GrpcStreamingFlushIntervalMs: 0,
-				GrpcStreamingMaxBatchSize:    2000,
+				GrpcStreamingMaxBatchSize:    1000000,
 			},
 			expectedErr: fmt.Errorf("grpc streaming flush interval must be positive number"),
 		},
@@ -120,7 +120,7 @@ func TestValidate(t *testing.T) {
 				GrpcEnable:                        true,
 				GrpcStreamingEnabled:              true,
 				GrpcStreamingFlushIntervalMs:      100,
-				GrpcStreamingMaxBatchSize:         2000,
+				GrpcStreamingMaxBatchSize:         1000000,
 				GrpcStreamingMaxChannelBufferSize: 0,
 			},
 			expectedErr: fmt.Errorf("grpc streaming channel size must be positive number"),