decouple grpc and non validating full node flags (#1400)

(cherry picked from commit 2fffe31)
dydxprotocol · Apr 25, 2024 · 93b609e · 93b609e
1 parent 2cd68a9
commit 93b609e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 12 deletions.
diff --git a/protocol/app/flags/flags.go b/protocol/app/flags/flags.go
@@ -94,10 +94,6 @@ func (f *Flags) Validate() error {
 		if !f.GrpcEnable {
 			return fmt.Errorf("grpc.enable must be set to true - grpc streaming requires gRPC server")
 		}
-
-		if !f.NonValidatingFullNode {
-			return fmt.Errorf("grpc-streaming-enabled can only be set to true for non-validating full nodes")
-		}
 	}
 	return nil
 }

diff --git a/protocol/app/flags/flags_test.go b/protocol/app/flags/flags_test.go
@@ -61,19 +61,18 @@ func TestValidate(t *testing.T) {
 				NonValidatingFullNode: true,
 			},
 		},
-		"failure - gRPC disabled": {
-			flags: flags.Flags{
-				GrpcEnable: false,
-			},
-			expectedErr: fmt.Errorf("grpc.enable must be set to true - validating requires gRPC server"),
-		},
-		"failure - gRPC streaming enabled for validating nodes": {
+		"success - gRPC streaming enabled for validating nodes": {
 			flags: flags.Flags{
 				NonValidatingFullNode: false,
 				GrpcEnable:            true,
 				GrpcStreamingEnabled:  true,
 			},
-			expectedErr: fmt.Errorf("grpc-streaming-enabled can only be set to true for non-validating full nodes"),
+		},
+		"failure - gRPC disabled": {
+			flags: flags.Flags{
+				GrpcEnable: false,
+			},
+			expectedErr: fmt.Errorf("grpc.enable must be set to true - validating requires gRPC server"),
 		},
 		"failure - gRPC streaming enabled with gRPC disabled": {
 			flags: flags.Flags{