address comments

Signed-off-by: Shrenuj Bansal <[email protected]>

indexer/packages/v4-protos/src/codegen/dydxprotocol/revshare/tx.rpc.msg.ts

@@ -5,7 +5,7 @@ import { MsgSetMarketMapperRevenueShare, MsgSetMarketMapperRevenueShareResponse
 
 export interface Msg {
   /**
-   * SetMarketMapperRevenueShare creates a new revenue share for a market
+   * SetMarketMapperRevenueShare sets the revenue share for a market
    * mapper.
    */
   setMarketMapperRevenueShare(request: MsgSetMarketMapperRevenueShare): Promise<MsgSetMarketMapperRevenueShareResponse>;

indexer/packages/v4-protos/src/codegen/dydxprotocol/revshare/tx.ts

@@ -1,15 +1,15 @@
 import { MarketMapperRevenueShareParams, MarketMapperRevenueShareParamsSDKType } from "./params";
 import * as _m0 from "protobufjs/minimal";
 import { DeepPartial } from "../../helpers";
-/** Message to create a blanket market mapper revenue share */
+/** Message to set the market mapper revenue share */
 
 export interface MsgSetMarketMapperRevenueShare {
   authority: string;
   /** Parameters for the revenue share */
 
   params?: MarketMapperRevenueShareParams;
 }
-/** Message to create a blanket market mapper revenue share */
+/** Message to set the market mapper revenue share */
 
 export interface MsgSetMarketMapperRevenueShareSDKType {
   authority: string;

proto/dydxprotocol/revshare/tx.proto

@@ -10,13 +10,13 @@ option go_package = "github.com/dydxprotocol/v4-chain/protocol/x/revshare/types"
 
 // Msg defines the Msg service.
 service Msg {
-  // SetMarketMapperRevenueShare creates a new revenue share for a market
+  // SetMarketMapperRevenueShare sets the revenue share for a market
   // mapper.
   rpc SetMarketMapperRevenueShare(MsgSetMarketMapperRevenueShare)
       returns (MsgSetMarketMapperRevenueShareResponse);
 }
 
-// Message to create a blanket market mapper revenue share
+// Message to set the market mapper revenue share
 message MsgSetMarketMapperRevenueShare {
   // The address that controls the module (the gov module account).
   option (cosmos.msg.v1.signer) = "authority";

protocol/x/revshare/keeper/msg_set_marketmapper_revenue_share_test.go

@@ -41,6 +41,16 @@ func TestSetMarketMapperRevenueShareParams(t *testing.T) {
 			},
 			expectedErr: "invalid authority",
 		},
+		"Failure - Empty Authority": {
+			msg: &types.MsgSetMarketMapperRevenueShare{
+				Params: types.MarketMapperRevenueShareParams{
+					Address:         constants.AliceAccAddress.String(),
+					RevenueSharePpm: 100_000,
+					ValidDays:       240,
+				},
+			},
+			expectedErr: "invalid authority",
+		},
 		"Failure - Invalid revenue share address": {
 			msg: &types.MsgSetMarketMapperRevenueShare{
 				Authority: lib.GovModuleAddress.String(),

protocol/x/revshare/types/params.go

@@ -8,7 +8,6 @@ import (
 // DefaultParams returns a default set of `x/revshare` market mapper parameters.
 func DefaultParams() MarketMapperRevenueShareParams {
 	return MarketMapperRevenueShareParams{
-		// TODO: is there a diff address this can be set to?
 		Address:         authtypes.NewModuleAddress(authtypes.FeeCollectorName).String(),
 		RevenueSharePpm: 0,
 		ValidDays:       0,