Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOB-930] Add ctx.Done() support to shutdown, make start-up wait time configurable, and add support for domain sockets for gRPC server and gRPC web server. #29

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

lcwik
Copy link

@lcwik lcwik commented Oct 25, 2023

The purpose of these changes is to be able to launch the Cosmos app from the command entry point instead of directly via dydx.NewApp in the e2e test framework.

ctx.Done() support and was added in 0.50 with cosmos#15041

server start up time was removed in 0.50 with cosmos#15041

So a lot of this change will be removed with the Cosmos 0.50 upgrade.

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@linear
Copy link

linear bot commented Oct 25, 2023

lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 25, 2023
… app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 25, 2023
… app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 25, 2023
… app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
…e configurable, and add support for domain sockets for gRPC server and gRPC web server.

ctx.Done() support and was added in 0.50 with cosmos#15041
server start up time was removed in 0.50 with cosmos#15041
lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 25, 2023
… app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
@lcwik lcwik merged commit bdf96fd into dydx-fork-v0.47.4 Oct 26, 2023
8 of 9 checks passed
@lcwik lcwik deleted the lukeclob930 branch October 26, 2023 18:30
lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 26, 2023
… app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
lcwik added a commit to dydxprotocol/v4-chain that referenced this pull request Oct 27, 2023
… app using cmd. (#703)

* [CLOB-930, CORE-29] Extend the e2e test framework to start the cosmos app using cmd.

This works towards enabling and passing in flags for flag based testing.
This also works towards enabling daemons on e2e app start-up once the daemons can be cleaned up.
This relies on dydxprotocol/cosmos-sdk#29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants