Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyring support #117

Closed
cjc7373 opened this issue Dec 26, 2021 · 3 comments · Fixed by #265
Closed

Keyring support #117

cjc7373 opened this issue Dec 26, 2021 · 3 comments · Fixed by #265
Labels
enhancement

Comments

@cjc7373
Copy link

cjc7373 commented Dec 26, 2021

By using libraries like keyring-rs, one can store secrets into some platform-native credential managers, like serect service in Linux. Thus it can store serects into a password manager like KeePass.

Hopefully this could replace the encrypt and decrypt command.
@dyc3
Copy link
Owner

dyc3 commented Dec 26, 2021

This is a great idea. Although, I still want to keep compatibility with SDA, so the encrypt and decrypt commands have to stay. Thanks for letting me know about this crate!

@dyc3
Copy link
Owner

dyc3 commented Dec 26, 2021

What implications does this have for allowing users to back up their 2FA credentials? Would it be better to just use the keyring to store the encryption password instead of the shared secret and stuff?

@cjc7373
Copy link
Author

cjc7373 commented Dec 26, 2021

I think this could be an opt-in feature. So people who enable it should have enough knowledge what they are doing and where to find their credentials.

@dyc3 dyc3 changed the title [Feature Request] keyring support Keyring support Jul 2, 2023
@dyc3 dyc3 mentioned this issue Jul 2, 2023
Merged
@dyc3 dyc3 closed this as completed in #265 Jul 2, 2023
dyc3 added a commit that referenced this issue Jul 2, 2023
@dyc3
Add support for storing encryption passkey in system keyring (#265)
7e94f76 
- add keyring package
- add keyring id field to manifest
- automatically attempt to load encryption passkey from keyring
- have decrypt delete the passkey on decrypt
- have encrypt command ask if it should store the passkey in the keyring
- fix lints

closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for storing encryption passkey in system keyring dyc3/steamguard-cli
2 participants
@dyc3 @cjc7373