wip: new jwt based authentication

[dyc3]

This PR will completely redo how we do authentication to use JWTs.

Why?

We are frequently pinging redis for session info. In fact, due to the way I shittily implemented auth tokens, we ping redis at a minimum of 3 times for every authenticated request: 1 because of express-session and 2 because of authTokenMiddleware.
In prod, we are sitting at around ~50k redis commands per day when we only have <100 simultaneous users peak most days. This is unsustainable, especially because I pay per command now.

Also, storing auth tokens in localstorage is not great. It doesn't really matter that much for this project, but still.
This time, I'm gonna take the time to do it right.

TODO

These would make this much easier to implement.

• Refactor all authenticated API endpoints to defer writing the body so we can set the jwt cookie in the response after all the processing has been done for the request. Express won't let us set headers after we call res.json().
• Start putting the auth token in a cookie, and accept it being provided either by the cookie or via Authorization header (like already do)
• Use a access token/refresh token pattern - where the access token only lives for the current session and the refresh token has an expiry. Upon a new session from the client, it should use the refresh token to get a new access token.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[cypress]

Passing run #1232 ↗︎

0

52

1

0

0

Details:

Merge cd55c60 into cc043a5...
Project: OpenTogetherTube	Commit: f4289039a0 ℹ️
Status: Passed	Duration: 02:10 💡
Started: Mar 7, 2024 3:31 PM	Ended: Mar 7, 2024 3:33 PM

Review all test suite changes for PR #1456 ↗︎