Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Persona Template Instructions for #115 #153

Merged
merged 19 commits into from
Jun 27, 2020

Conversation

nelsonic
Copy link
Member

@nelsonic nelsonic commented Jun 24, 2020

Busy adding more detail to the Personas doc including

This is useful for: dwyl/app#213

@nelsonic
Copy link
Member Author

bitmoji

@nelsonic
Copy link
Member Author

This is what I have so far:
image

Will add to dwyl/app#213 once I've finalised this PR.

@nelsonic nelsonic changed the title Add Persona Template Instructions Add Persona Template Instructions for #115 Jun 27, 2020
@nelsonic
Copy link
Member Author

Template: for #115

image

@nelsonic nelsonic assigned iteles and unassigned nelsonic Jun 27, 2020
@nelsonic nelsonic requested a review from iteles June 27, 2020 16:36
@nelsonic
Copy link
Member Author

@iteles this is PR is ready for review. :shipit:
Not urgent, but a really nice to have for clarifying who we are building our App for dwyl/app#213 👩‍🏫
Thanks. 🌻

iteles
iteles previously approved these changes Jun 27, 2020
Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit with some minor typos and left a suggestion below :)
Thanks for putting this all together @nelsonic!

@iteles iteles assigned nelsonic and unassigned iteles Jun 27, 2020
@iteles iteles removed the in-review label Jun 27, 2020
Co-authored-by: Ines Teles Correia <[email protected]>
@nelsonic
Copy link
Member Author

@iteles I've committed your suggestion to the PR. Please re-review and merge when you can. Thanks again. 👍

Copy link
Member

@iteles iteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nelsonic, looks great ✨

@iteles iteles merged commit 4e4026d into master Jun 27, 2020
@iteles iteles deleted the add-persona-template-instructions-issue#213 branch June 27, 2020 23:23
@nelsonic
Copy link
Member Author

@iteles hope it’s helpful for you (and the team/community) when creating personas. ☀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants