Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit response #68

Merged
merged 46 commits into from
May 10, 2017
Merged

Edit response #68

merged 46 commits into from
May 10, 2017

Conversation

jackcarlisle
Copy link
Member

@jackcarlisle jackcarlisle commented Apr 27, 2017

ready for review

  • adds the ability to edit a response to feedback after it has been made
  • includes all previous commits

#61

@codecov-io
Copy link

codecov-io commented Apr 27, 2017

Codecov Report

Merging #68 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #68    +/-   ##
======================================
  Coverage     100%   100%            
======================================
  Files           5     17    +12     
  Lines          17    192   +175     
======================================
+ Hits           17    192   +175
Impacted Files Coverage Δ
web/router.ex 100% <ø> (ø) ⬆️
test/support/conn_case.ex 100% <ø> (ø) ⬆️
web/controllers/response_controller.ex 100% <100%> (ø)
web/controllers/session_controller.ex 100% <100%> (ø)
web/controllers/feedback_controller.ex 100% <100%> (ø) ⬆️
web/models/feedback.ex 100% <100%> (ø)
web/controllers/forum_controller.ex 100% <100%> (ø)
web/models/response.ex 100% <100%> (ø)
test/support/test_helpers.ex 100% <100%> (ø)
web/controllers/auth.ex 100% <100%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df38df4...5f39aaa. Read the comment docs.

@nelsonic
Copy link
Member

nelsonic commented May 5, 2017

@jackcarlisle will take at look at this (mega) PR over the weekend ...

@jackcarlisle
Copy link
Member Author

@nelsonic awesome thanks!

@nelsonic
Copy link
Member

Ran locally got:
image

image

🎉

@nelsonic
Copy link
Member

nelsonic commented May 10, 2017

However ... getting channel error in terminal:
image

@jackcarlisle please create an issue to investigate this separately from this PR. 👍

@nelsonic
Copy link
Member

Feedback left:
image

DB record:
image

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcarlisle this is superb! 😍
Sorry it's taken me a few days to review.
I'm quite slow at reading code
(especially so with "mega" PRs...)
and keep getting interrupted ...

But this is an excellent start to the Feedback project! 🎉
Thanks for all your hard work! ❤️ ✅

@nelsonic nelsonic merged commit e4fac46 into master May 10, 2017
@nelsonic nelsonic deleted the edit-response branch May 10, 2017 11:31
@nelsonic
Copy link
Member

@jackcarlisle please delete any unused branches. 👍
and ... #34 ? 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants