Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create /admin Page to test Referrer/Redirection #46

Closed
3 tasks done
nelsonic opened this issue Apr 12, 2020 · 1 comment
Closed
3 tasks done

Create /admin Page to test Referrer/Redirection #46

nelsonic opened this issue Apr 12, 2020 · 1 comment
Assignees
@nelsonic
Labels
enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person T25m Time Estimate 25 Minutes

Comments

@nelsonic
Copy link
Member

nelsonic commented Apr 12, 2020 •
edited
Loading

At present the / (root route) of the Auth App displays the login buttons: http://localhost:4000/
image
This does not allow us to test redirection (back to the originating URL after successful login).
I suggest we create a different page in the Admin App to serve as a test for redirection.

Todo

  • Create /admin route
  • Extract referer from request headers
  • Include referer in state when constructing url for 3rd Party Auth
@nelsonic nelsonic added enhancement New feature or enhancement of existing functionality T25m Time Estimate 25 Minutes in-progress An issue or pull request that is being worked on by the assigned person labels Apr 12, 2020
@nelsonic nelsonic self-assigned this Apr 12, 2020
nelsonic added a commit that referenced this issue Apr 13, 2020
@nelsonic
add /admin route, handler and template for testing referer #46
9d3887c
@nelsonic nelsonic mentioned this issue Apr 16, 2020
Merged
12 tasks
@nelsonic
Copy link
Member Author

included in #43 ✅

nelsonic added a commit that referenced this issue Apr 16, 2020
@nelsonic
create tests for extracting referer headers for #46
5083e28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nelsonic nelsonic

Labels
enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person T25m Time Estimate 25 Minutes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nelsonic