Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove WAL operations that are not page writes #13

Open
dwsteele opened this issue Jun 5, 2018 · 0 comments
Open

Remove WAL operations that are not page writes #13

dwsteele opened this issue Jun 5, 2018 · 0 comments
Assignees
@dwsteele
Labels
enhancement

Comments

@dwsteele
Copy link
Owner

dwsteele commented Jun 5, 2018

Some WAL operations perform some logic rather than just rewriting a page. This can be replayed differently on the replica and are harder to parse in the WAL for effects. Eliminate them if possible.
@dwsteele dwsteele self-assigned this Jun 5, 2018
dwsteele pushed a commit that referenced this issue Mar 25, 2021
@robertmhaas
Fix portability issues in pg_amcheck's 004_verify_heapam.pl.
6611256 
Test #12 overwrote a 1-byte varlena header to make it look like the
initial byte of a 4-byte varlena header, but the results were
endian-dependent. Also, the byte "abc" that followed the overwritten
byte would be interpreted differently depending on endian-ness.
Overwrite 4 bytes instead, in an endian-aware manner.

Test #13 accidentally managed to depend on TOAST_MAX_CHUNK_SIZE,
which varies slightly depending on MAXIMUM_ALIGNOF. That's not
the point anyway, so make the regexp insensitive to the expected
number of chunks.

Mark Dilger

Discussion: http://postgr.es/m/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwsteele dwsteele

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dwsteele