github actions & mypy #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like in order to get this to run @dwolfhub might need to open a pull request for this branch or something. You can see it's working fine on my fork: |
|
Hey this is great! Thanks! |
|
@fuhrysteve re: typing i haven't looked into it really, so if you think it's good to start where they left off i'd love to see that PR. thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to
If this seems like a good direction to go let me know! I'd be happy to put together another PR dropping support for python 2 and adding some typing. Looks like #57 has gotten started on it already, not sure if it's worthwhile picking up where @septatrix left off or starting fresh.