Modifies error checking code in OpenGL.cs to accommodate multiple err… #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ors. Also, if a PreGLCall is made before calling a closing PostGLCall, that could leave unreported errors that this new modification will now report.
Codecov Report
@@ Coverage Diff @@
## master #214 +/- ##
======================================
Coverage 3.16% 3.16%
======================================
Files 90 90
Lines 3697 3697
Branches 657 657
======================================
Hits 117 117
Misses 3575 3575
Partials 5 5 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ors. Also, if a PreGLCall is made before calling a closing PostGLCall, that could leave unreported errors that this new modification will now report.
This modification accounts for the fact that OpenGL calls can set multiple error flags. It follows instructions given in OpenGL documentation: "Thus, glGetError should always be called in a loop, until it returns GL_NO_ERROR, if all error flags are to be reset."
This is one of several modifications I make to the SharpGL source code any time I download the latest version for use in my projects. I intent to put out individual pull requests for each of them, hoping to improve the project for all. Thank you for your consideration.