Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Markdown is being interpreted incorrectly. #255

Closed
saraid opened this issue Mar 7, 2023 · 3 comments · Fixed by #275 or #276
Closed

bug: Markdown is being interpreted incorrectly. #255

saraid opened this issue Mar 7, 2023 · 3 comments · Fixed by #275 or #276

Comments

@saraid
Copy link

saraid commented Mar 7, 2023

I haven't tracked down the root of the issue, but this line

This is better - we've eliminated some invalid addresses, _test123.effective-shell.com_, _@yahoo.com_ and _dave@_.

is being interpreted incorrectly by Docusaurus. Specifically, [email protected]_ is generating a non-italicized, valid [email protected] email address as a mailto link. GFM is handling it fine, though.

It's a very minor issue, but it detracts from the point of the sentence. I can imagine fixing it by choosing a different bit of formatting, or perhaps adding a leading space, but I'm not familiar with Docusaurus' quirks, so it's hard to advise a solution.

dwmkerr added a commit that referenced this issue May 4, 2023
dwmkerr added a commit that referenced this issue May 4, 2023
@dwmkerr
Copy link
Owner

dwmkerr commented May 4, 2023

Thanks @saraid - good spot! I've changed these fragments to use code formatting which I think is more consistent with what we have in the rest of the chapter, and fixes the formatting issues. Thanks for raising this!

@dwmkerr
Copy link
Owner

dwmkerr commented May 4, 2023

@all-contributors please add @saraid for review

@allcontributors
Copy link
Contributor

@dwmkerr

I've put up a pull request to add @saraid! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants