Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add UNGEGN names and update Wikipedia publisher and parsers #81

Merged
merged 5 commits into from
May 20, 2024
Merged

feat: Add UNGEGN names and update Wikipedia publisher and parsers #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5c5047a
fix: Wikipedia publisher
dwilkie May 19, 2024
52745e9
WIP
dwilkie May 19, 2024
259d4b7
Add UNGEGN transliterations
dwilkie May 20, 2024
fb659f8
Update README
dwilkie May 20, 2024
58ecdc5
WIP
dwilkie May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,11 @@ And then execute:

# Return the district's province name in latin
district.province.name_latin
# => Phnom Penh
# => "Phnom Penh"

# Return the district's province name in UNGEGN
district.province.name_ungegn
# => "Phnum Pénh"

# Working with Communes (ឃុំ / សង្កាត់)

Expand Down
5 changes: 5 additions & 0 deletions bin/parse_data
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ require "pumi/data_source/wikipedia"

Pumi::DataSource::NCDD.new.load_data!

Pumi::DataSource::Wikipedia.new(
scraper: Pumi::DataSource::Wikipedia::CambodianProvincesScraper.new,
data_file: Pumi::DataFile.new(:provinces)
).load_data!

Pumi::DataSource::Wikipedia.new(
scraper: Pumi::DataSource::Wikipedia::CambodianDistrictsScraper.new,
data_file: Pumi::DataFile.new(:districts)
Expand Down
Loading