Extending options object in renderPartial

[pwalczyszyn]

In the renderPartial function I changed _.defaults to _.extend. This fixes a problem of not being able to have different options in multiple file rendering setup.

[dwightjack]

Was thinking the same thing, but i noticed that that way you're extending the main option object.

Wouldn't it be better to use an empty object as first argument? Also providing a default when data is not set would prevent errors:

_.extend({}, options, {filename: fpath}, data || {})

[pwalczyszyn]

Yeah, you are right it would be even better this way.

On Wednesday, March 12, 2014, Marco Solazzi [email protected]
wrote:

Was thinking the same thing, but i noticed that that way you're extending
the main option object.

Wouldn't it be better to use an empty object as first argument? Also
providing a default when data is not set would prevent errors:

_.extend({}, options, {filename: fpath}, data || {})

Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-37465654
.

[dwightjack]

Ok merged and added the fix. Pushed a new versione 0.2.5

[pwalczyszyn]

Awesome!
Thx
P.

On Thursday, March 13, 2014, Marco Solazzi [email protected] wrote:

Ok merged and added the fix. Pushed a new versione 0.2.5

Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-37510208
.