Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Py27 and Win32; add Py38 #75

Merged
merged 8 commits into from
Jul 6, 2020
Merged

Drop Py27 and Win32; add Py38 #75

merged 8 commits into from
Jul 6, 2020

Conversation

dwhswenson
Copy link
Owner

Currently our Travis script has a Py27/MDTraj dev test job. However, MDTraj has made changes that are incompatible with Py27. We'd already discussed dropping Py27 and Win32 from tests (#69 (comment)), so I'm doing it now.

While I'm at it, I'm including Py38 in our test matrix (overdue!). Note that the next release will be the last one to guarantee support Python 3.6 (by NEP29 we could already drop 3.6, but I'm going to take a slightly more conservative approach.)

@dwhswenson dwhswenson added misc PR upstream_changed PR in response to changes in dependencies labels Jun 30, 2020
@dwhswenson
Copy link
Owner Author

Going to close/open to see if I can get travis to trigger

@dwhswenson dwhswenson closed this Jun 30, 2020
@dwhswenson dwhswenson reopened this Jun 30, 2020
@dwhswenson
Copy link
Owner Author

Summary of what's in here:

  • We no longer test against Python 2 at all
  • We no longer test against Win32 at all
  • Travis tests Python 3.6, 3.7, 3.8, and considers 3.8 the "canonical" version (and 3.8 is tested against MDTraj current master as well as MDTraj release; others only tested against MDTraj release)
  • AppVeyor tests Python 3.6, 3.7. (It seems that no one is using AppVeyor's Miniconda38 yet; AppVeyor lists it as deployed, but I couldn't find any evidence of widespread use)

Also, I migrated us to travis-ci.com (from the .org). There's a general (but very gentle) push from the Travis folks to go that direction.

As a thought for the future, it might make sense for testing against MDTraj master to be skipped on the stable branch. But that's for a future PR.

@dwhswenson dwhswenson requested a review from sroet June 30, 2020 11:37
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 question, 1 proposed change (feel free to ignore), and some commented out leftover code, looks good to me otherwise

appveyor.yml Outdated Show resolved Hide resolved
appveyor.yml Outdated Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
Copy link
Collaborator

@sroet sroet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@dwhswenson dwhswenson merged commit e63034d into master Jul 6, 2020
@dwhswenson dwhswenson deleted the drop-py27-win32 branch July 6, 2020 09:33
This was referenced Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc PR upstream_changed PR in response to changes in dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants