Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias in multi_logger #161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

motoroller95
Copy link

@motoroller95 motoroller95 commented Jun 12, 2020

When I use MultiLogger#log I expect that all loggers will receive my message. Actually Logger#log is alias to Logger#add and because ruby alias is not apply to child classes, when I write MultiLogger.new(...).log loggers will no receive message, but Logger#log will

@dwbutler Hi! pls review this

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #161 into master will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   92.68%   92.64%   -0.04%     
==========================================
  Files          64       64              
  Lines        1668     1673       +5     
==========================================
+ Hits         1546     1550       +4     
- Misses        122      123       +1     
Impacted Files Coverage Δ
lib/logstash-logger/multi_logger.rb 75.34% <100.00%> (+3.12%) ⬆️
spec/multi_logger_spec.rb 100.00% <100.00%> (ø)
lib/logstash-logger/device/kinesis.rb 88.88% <0.00%> (-5.56%) ⬇️
lib/logstash-logger/device/firehose.rb 88.88% <0.00%> (-5.56%) ⬇️
lib/logstash-logger/device/tcp.rb 94.11% <0.00%> (-1.97%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8f5403...2065ef4. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants