Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require specific AWS gems for every class #136

Merged
merged 2 commits into from
Jan 11, 2018
Merged

Require specific AWS gems for every class #136

merged 2 commits into from
Jan 11, 2018

Conversation

syabruk
Copy link
Contributor

@syabruk syabruk commented Oct 4, 2017

aws-sdk gem has been split into several gems: https://github.com/aws/aws-sdk-ruby/blob/master/V3_UPGRADING_GUIDE.md
The changed code tries to require a new gem first but keeps backward compatibility with the previous aws-sdk gem version.

@syabruk
Copy link
Contributor Author

syabruk commented Oct 4, 2017

I'll fix specs

@dwbutler dwbutler self-requested a review January 9, 2018 18:29
Repository owner deleted a comment from codecov-io Jan 11, 2018
dwbutler
dwbutler approved these changes Jan 11, 2018
View reviewed changes
Copy link
Owner

@dwbutler dwbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In your documentation, I think you got it backwards. The aws-sdk gem should only be used for version < 3.0.

@dwbutler dwbutler merged commit e5acffd into dwbutler:master Jan 11, 2018
syabruk referenced this pull request Jan 11, 2018
@dwbutler
Version bump, documentation updates, changelog [ci-skip]
28d4988
@syabruk syabruk deleted the require-specific-aws-gems branch January 11, 2018 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dwbutler dwbutler dwbutler approved these changes

Assignees
No one assigned
Labels
accepted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@syabruk @dwbutler